-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable workflow: Enable workflow item deletion without publishing it (DS-3926) #2076
Conversation
The item is removed permanently, and before deleting the item DELETE permission is checked
Fixed some identations.
Closing and opening to restart tests |
@santit96, it's been a while since you submitted, but a belated thanks for the pr I am having some difficulty actually testing the functionality described, I haven't used the workflow process very much could you explain how to use the described feature in this PR? |
Hi @J4bbi! Sure! Here are the steps to use the feature:
And that's it, the workflow item no longer exists |
Thanks @santit96 I don't know why but I don't get that option, I am pretty sure I have done everything correctly, I am building your branch with the two commits and using docker-compose. these are the only, and standard options I get. Is it possible this branch is missing a commit? I've made the submission with a non-admin and I've set admin to be the group assigned to WF2 Accept/Reject/Edit Metadata Step. I've also peppered the xmlworkflow AcceptEditRejectAction class with log.info and System.out.printlns but I get nothing in the logs. I'm feeling like I need a serious sanity check. |
@J4bbi I'm pretty sure that i have pushed all the commits, but i made this PR long ago so i'll check just in case! |
@santit96, can you also confirm if this PR is intended for configurable xmlworkflow or the basic workflow? see: https://wiki.lyrasis.org/display/DSDOC6x/Configurable+Workflow |
It is for configurable xmlworkflow |
I checked the feature again with the branch of this PR (also checked that i have the same commits this PR has), and everything works fine for me. I seems to me that there is a permissions issue. Perhaps the problem is that the the group assigned to WF2 Accept/Reject/Edit Metadata Step does not have DELETE permissions over the items, you can try giving DELETE permissions over the collection to that particular admin. |
@santit96 and @J4bbi : I'd recommend this PR be updated to go against Therefore, I'd like to ask that you consider adding this into 7.x instead of 6.x. In the 7.0 platform, it is possible for Administrators in the system to delete any item in Workflow (which would solve the DS-3926 ticket in a different manner). But, I don't believe it's possible yet for reviewers to delete items currently in workflow. |
The whole issue is described here:
https://jira.duraspace.org/browse/DS-3926